ci: fix flaky $zstd_ratio log race in ASAN smoke test#51
Merged
Conversation
$zstd_ratio is written in nginx's log phase (after the response body is flushed), so test_encoding.py could read logs/zstd_ratio.log before the line was written — intermittent under the slower ASAN binary, failing as "the ratio code path did not run". validate_ratio_log now polls for the line (10s budget) instead of reading once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$zstd_ratio is written in nginx's log phase (after the response body is flushed), so
test_encoding.pycould readlogs/zstd_ratio.logbefore the line was written — intermittent under the slower ASAN binary, failing as "the ratio code path did not run" (e.g. master run 27309940739).validate_ratio_lognow polls for the line (10s budget) instead of reading once.No behavior change to the module; test-harness only.