Skip to content

imagePullSecrets on deployments for actorhosts #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sleipnir merged 3 commits into from
Mar 4, 2025
Merged

imagePullSecrets on deployments for actorhosts #431

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6455bf1
pull secret on deployments
eliasdarruda Mar 2, 2025
40509f7
pull secret fix
eliasdarruda Mar 3, 2025
d8185d4
fix: correct semantic for image pull secrets
Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions spawn_operator/spawn_operator/lib/spawn_operator/k8s/proxy/deployment.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ defmodule SpawnOperator.K8s.Proxy.Deployment do
}
|> maybe_put_node_selector(topology)
|> maybe_put_node_tolerations(topology)
|> maybe_put_image_pull_secrets(host_params)
|> maybe_put_volumes(params, erlang_mtls_enabled)
|> maybe_set_termination_period(params)
}
Expand Down Expand Up @@ -456,6 +457,15 @@ defmodule SpawnOperator.K8s.Proxy.Deployment do

defp maybe_put_node_tolerations(spec, _), do: spec

defp maybe_put_image_pull_secrets(
spec,
%{"imagePullSecrets" => image_pull_secrets} = _host_params
) do
Map.merge(spec, %{"imagePullSecrets" => image_pull_secrets})
Comment thread
sleipnir marked this conversation as resolved.
Outdated
end

defp maybe_put_image_pull_secrets(spec, _), do: spec

defp maybe_put_ports_to_host_container(spec, %{"ports" => ports}) do
Map.put(spec, "ports", ports)
end
Expand Down
7 changes: 7 additions & 0 deletions spawn_operator/spawn_operator/lib/spawn_operator/versions/api/v1/actor_host.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,13 @@ defmodule SpawnOperator.Versions.Api.V1.ActorHost do
properties:
image:
type: string
imagePullSecrets:
Comment thread
sleipnir marked this conversation as resolved.
Outdated
type: array
items:
type: object
properties:
name:
type: string
volumeMounts:
type: array
items:
Expand Down