Fix(electrum-pool): use call_async instead of any_client for full scans#887
Merged
Einliterflasche merged 1 commit intomasterfrom Feb 23, 2026
Merged
Conversation
Instead of relying on the single electrum server to work for the full scan (which is required to successfully start the app), we use the electrum pool fallback mechanism (try other servers/clients after one errored). This tries to address the "Failed to initialize Bitcoin wallet: EOF" repeatedly reported, for example in #886.
|
Id test this by adding a few non functional electrum servers to your settings. |
|
bugbot run |
|
I'm fine with merging this if you tested this manually once. |
Author
|
Works with a fictional server at the top of the list, and at the bottom of the list. Does not work with zero functional servers (as expected). I'm merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on the single electrum server to work for the full scan (which is required to successfully start the app), we use the electrum pool fallback mechanism (try other servers/clients after one errored).
This tries to address the "Failed to initialize Bitcoin wallet: EOF" repeatedly reported, for example in #886.
@binarybaron is there any reason we didn't do this before? I had to move the construction of the FullScanRequest into the closure because of trait bounds.
Closes #886.