feat(orchestrator): ship bitcoind/monerod/electrs logs via promtail#1048
Open
binarybaron wants to merge 2 commits into
Open
feat(orchestrator): ship bitcoind/monerod/electrs logs via promtail#1048binarybaron wants to merge 2 commits into
binarybaron wants to merge 2 commits into
Conversation
Add a docker-socket-proxy service that exposes the read-only container API so promtail can tail the node daemons' stdout without holding the docker socket itself. Node logs share host=<instance> with the asb logs and add job=node + container=<name>.
Author
|
bugbot run |
promtail's docker_sd_configs calls the Docker /networks API to compute the __meta_docker_network_* labels for every target. The socket proxy (tecnativa/docker-socket-proxy) returns 403 for that path unless NETWORKS=1 is set, which makes the whole target refresh fail and ships zero node logs. POST stays disabled, so this only grants GET on /networks - no container or network mutation is exposed.
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5e2f406. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the promtail shipper (#1044) to also send the bitcoind, monerod, and electrs container logs to Loki. A docker-socket-proxy container holds the docker socket and exposes only the read-only container API, so promtail tails the daemons' stdout via docker_sd_configs without itself getting socket access. The node logs share host= with the asb logs and add job=node + container=.