Skip to content

fix: remove hardcoded OAuth client_secret from frontend #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobostay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove hardcoded OAuth client_secret from frontend #1637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,10 @@ export default function Login() {
formData.append('code_verifier', code_verifier || '');
formData.append('code', code);
formData.append('grant_type', 'authorization_code');
formData.append('client_id', 'aa49cdd0-318e-46bd-a540-0f1e5f2b391f');
formData.append('client_id', import.meta.env.VITE_STACK_CLIENT_ID || '');
formData.append(
'client_secret',
'pck_t13egrd9ve57tz52kfcd2s4h1zwya5502z43kr5xv5cx8'
import.meta.env.VITE_STACK_CLIENT_SECRET || ''
);

try {
Expand Down
9 changes: 9 additions & 0 deletions src/vite-env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@

/// <reference types="vite/client" />

interface ImportMetaEnv {
readonly VITE_STACK_CLIENT_ID?: string;
readonly VITE_STACK_CLIENT_SECRET?: string;
}

interface ImportMeta {
readonly env: ImportMetaEnv;
}

interface Window {
// expose in the `electron/preload/index.ts`
ipcRenderer: import('electron').IpcRenderer;
Expand Down