fix: use urlencode for OAuth authorize URL parameters#1636
Open
hobostay wants to merge 1 commit into
Open
Conversation
OAuth authorize URLs in Slack, Notion, X, and Google adapters were constructed via f-string interpolation, leaving parameters like redirect_uri, scope, and state vulnerable to breakage with special characters (spaces, ampersands, etc). LinkedIn already used urlencode. Switch all adapters to use urlencode for proper URL encoding. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urlencode()in Slack, Notion, X (Twitter), and Google OAuth adapters (server/app/core/oauth_adapter.py)redirect_uri,scope, andstatecould contain special characters (spaces, ampersands, Unicode) that would break the URL when interpolated directlyurlencodecorrectly — this brings the other adapters in lineself.scope.replace(' ', '%20')is now handled properly byurlencodeTest plan
🤖 Generated with Claude Code