fix: replace bare except clause with Exception in WebSocket heartbeat#1635
Open
hobostay wants to merge 1 commit into
Open
fix: replace bare except clause with Exception in WebSocket heartbeat#1635hobostay wants to merge 1 commit into
hobostay wants to merge 1 commit into
Conversation
A bare `except:` catches everything including SystemExit and KeyboardInterrupt, making it impossible to gracefully shut down the server. Changed to `except Exception:` to match the intent while allowing system signals to propagate. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
except:clause withexcept Exception:inserver/app/domains/trigger/api/trigger_execution_controller.pyline 339except:catches everything includingSystemExit,KeyboardInterrupt, andGeneratorExit, which prevents graceful server shutdown and violates PEP 8except Exception:which still catches all runtime errors but allows system-level signals to propagate correctlyTest plan
🤖 Generated with Claude Code