Open
Conversation
… in the etree code
…d to rnage() in expand_dim() This is done along side fixing the grossly pessimising `list()` calls on the resulting range objects in the index handling as this makes for a huge allocation and a lot of churn when dealing with SVDs with large ranges specified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue that cropped up while using the plugin with the ESP32-C3's SVD, which extensively relies on dimension ranges.
The plugin would crash and fail to read the SVD when it hit one of the
dimnode range specifications due to trying to pass a string as the argument torange(). This is the resulting fix after digging into why, and a small optimisation to this code by dropping the forcedlist()expansions which sped loading up a fair bit, while reducing memory utilisation.We've also added some type annotations which helped us in diagnosing the types issue and what exactly was going on.