Skip to content

Comments

Migrate from cron to pure python#9

Open
debMan wants to merge 14 commits intoehcaning:masterfrom
debMan:master
Open

Migrate from cron to pure python#9
debMan wants to merge 14 commits intoehcaning:masterfrom
debMan:master

Conversation

@debMan
Copy link

@debMan debMan commented Feb 6, 2023

I wrote some changes to migrate from corn to pure Python.

Changes:

  • Add .gitignore and .dockerignore
  • Handle new Divar changes to posts
  • Update README, and describe why tokens.json is mounted directly.
  • Remove cron and use raw Python and Dockerfile

Suggestion for further work:

  • Handle signals, while loop is not a good choice.
  • Enhance logging.

@debMan debMan marked this pull request as ready for review August 25, 2023 10:42
AmirAref and others added 6 commits August 26, 2023 23:20
* use python-telegram-bot module
* create requirements.txt file
* change the proxy config in the `.env-sample` file
* use the PTB module to connect telegram
* change some code styles
* use the "ad" model instead of the "house" name with pydantic
* remove some redundant functions
* fix some indents
* fetch multiple images from the ad page and send an album for more than one image
* change docker-compose
* change the get images method
* use the divar API instead of scraping
* get the full description
* change the extracted data and tokens process
* add price to ad details
* add emojis in the messages
* fix some bugs
* save new tokens and old tokens (merge)
* ignore the ad if failed to get the data
* fix fetch data for empty images
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants