Add support for category corrections with gradients#62
Open
ligerlac wants to merge 11 commits intoeguiraud:mainfrom
Open
Add support for category corrections with gradients#62ligerlac wants to merge 11 commits intoeguiraud:mainfrom
ligerlac wants to merge 11 commits intoeguiraud:mainfrom
Conversation
Collaborator
|
Can you rebase/merge the current main branch? I can't seem to do that myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrections of type 'Category' are currently not supported because discrete choices are inherently non differentiable. Consider the
phimodexample from the correctionlib documentation (link):Creating a correction with gradient like so
fails with
ValueError: "Correction 'categorical' contains the unsupported operation type 'Category'". Despitephimodbeing non-differentiable w.r.t. to the discrete inputq, it is, in principle, differentiable wr.t.phi.This PR adds support to Category corrections so that they can be differentiated w.r.t. to a subset of their inputs:
Also supports string categorical choices (e.g. "up" / "down" in systematic uncertainties).