Skip to content

Conversation

@yihozhang
Copy link
Collaborator

TODO

Add test

@yihozhang yihozhang requested a review from a team as a code owner May 9, 2025 09:21
@yihozhang yihozhang requested review from saulshanabrook and removed request for a team May 9, 2025 09:21
@codspeed-hq
Copy link

codspeed-hq bot commented May 9, 2025

CodSpeed Performance Report

Merging #563 will improve performances by 30.9%

Comparing yihozhang-extraction-cache (052a330) with main (8dcffb8)

Summary

⚡ 1 improvements
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
extract-vec-bench 107.4 ms 82.1 ms +30.9%

@Alex-Fischman
Copy link
Collaborator

I think we aren't planning to merge this, so mark as draft?

@Alex-Fischman Alex-Fischman requested review from oflatt and removed request for oflatt May 12, 2025 20:33
@Alex-Fischman Alex-Fischman marked this pull request as draft May 12, 2025 20:33
@Alex-Fischman Alex-Fischman removed the request for review from saulshanabrook May 13, 2025 20:22
@saulshanabrook
Copy link
Member

We just remembered this PR... @noahhuck implemented a new multi extract command in experimental (egraphs-good/egglog-experimental#39). If we end up adding this that may be less important for performance reasons but still useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants