[WIP] Update to address feedback on moving data in non-local mode #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: oflatt <8523445+oflatt@users.noreply.github.com>
oflatt
approved these changes
Jan 19, 2026
Copilot stopped work on behalf of
oflatt due to an error
January 19, 2026 19:17
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where PROFILE_JSON was referencing the old DATA_DIR location after the directory was moved to OUTPUT_DATA_DIR in non-local mode. The fix ensures that gzip operates on the correct file path after the move operation.
Changes:
- Updated line 112 to directly reference
$OUTPUT_DATA_DIR/profile.jsoninstead of the now-stale$PROFILE_JSONvariable in non-local mode
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.