ci fix attempt #230
Open
ci fix attempt #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligi
reviewed
Jan 27, 2023
Comment on lines
+29
to
+32
| # - python-version: "3.11" | ||
| # toxenv: py311-core | ||
| # - python-version: "3.11" | ||
| # toxenv: py311-integration |
Member
There was a problem hiding this comment.
Should we maybe just remove it instead of commenting it out?
Author
There was a problem hiding this comment.
Not sure; do we have plans to support it? I guess the cleanest thing is to actually solve whatever is causing 3.11 to not work, but on the other hand maybe it doesn't matter
Member
There was a problem hiding this comment.
I really would remove it before merging - having this just commented out is not a good style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
How was it fixed?
Cute Animal Picture