Open
Conversation
eerimoq
reviewed
Feb 10, 2026
| ) | ||
| } | ||
| .frame(width: CGFloat(modular.width) + CGFloat(maxHistory) * histWidth) | ||
| .frame(width: CGFloat(modular.width) + CGFloat(maxHistory - 1) * histWidth) |
Owner
There was a problem hiding this comment.
hmm, looks odd to allow negative width
Contributor
Author
There was a problem hiding this comment.
It wouldn't result in negative width for the scoreboard, just removes the width of one score box. The default results in a wider display than it should be. I updated the PR with an alternative way to address this.
eerimoq
reviewed
Feb 10, 2026
| private func teamName(team: SettingsWidgetModularScoreboardTeam) -> some View { | ||
| Text(team.name) | ||
| .font(.system(size: fontSize())) | ||
| .font(.system(size: fontSize(), weight: .bold)) |
Owner
There was a problem hiding this comment.
the bold setting is on the next line. you want to force team name in bold? I like it configurable.
Contributor
Author
There was a problem hiding this comment.
The configuration option doesn't work for me. It's fine to leave as it is, I can look into why the bold toggle doesn't seem to impact the team name later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.