Merged
Conversation
|
The spec from this PR is available at https://preview.sesh.rs/previews/eecs280staff/tutorials/235/. (Available until Sun Dec 07 2025.) |
awdeorio
approved these changes
Oct 6, 2025
Contributor
awdeorio
left a comment
awdeorio
left a comment
There was a problem hiding this comment.
LGTM. It would be nice to have a very short description of the change and the motivation in the PR. That helps with future updates.
jamesjuett
approved these changes
Nov 7, 2025
Contributor
jamesjuett
left a comment
jamesjuett
left a comment
There was a problem hiding this comment.
I made an edit to the PR description to include a brief summary of changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #211 by adding
-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_DEBUGto the sanitizer options recommended for macOS.