build: updated ubuntu version to latest#99
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions runner operating system from the specific ubuntu-20.04 version to ubuntu-latest across workflow files. This ensures the workflows automatically use the latest Ubuntu LTS version supported by GitHub Actions.
Key Changes:
- Updated CI and PyPI publishing workflows to use
ubuntu-latestinstead ofubuntu-20.04
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/publish_pypi.yml |
Updated PyPI publishing job runner to use ubuntu-latest |
.github/workflows/ci.yml |
Updated CI test matrix to use ubuntu-latest for test execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| commands = | ||
| pip install -U pip | ||
| pytest --basetemp={envtmpdir} |
There was a problem hiding this comment.
The removal of "pip install -U pip" from the commands section appears to be unintentional. While setuptools and wheel are now upgraded in the commands_pre section, pip itself is no longer being upgraded. Consider adding "pip install -U pip" to the commands_pre section to ensure pip is also up-to-date before running tests.
| run: pip install -r requirements/pip.txt | ||
|
|
||
| - name: Install build tools | ||
| run: pip install --upgrade setuptools wheel |
There was a problem hiding this comment.
Inconsistent setuptools and wheel version specifications across files. In tox.ini, specific minimum versions are specified (setuptools>=65, wheel>=0.38), while in publish_pypi.yml, no version constraints are specified. Consider using consistent version constraints across both files to ensure reproducible builds.
| run: pip install --upgrade setuptools wheel | |
| run: pip install --upgrade "setuptools>=65" "wheel>=0.38" |
2 participants
Description
Updating the latest version of ubuntu
Ticket Reference
https://2u-internal.atlassian.net/browse/BOMS-285
Deprecated universal = 1 in setup.cfg - This setting for Python 2/3 universal wheels is obsolete and causes TypeError with modern wheel versions