chore: Update NGINX_HSTS_MAX_AGE for edxapps. ENT-11139#294
Open
chore: Update NGINX_HSTS_MAX_AGE for edxapps. ENT-11139#294
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the HSTS (HTTP Strict Transport Security) configuration across all nginx site templates to align with HSTS preload best practices.
- Standardizes HSTS headers to include
includeSubDomainsandpreloaddirectives across all templates - Increases the default
NGINX_HSTS_MAX_AGEfrom 1 year (31536000 seconds) to 2 years (63072000 seconds) - Replaces hardcoded max-age values with the configurable
{{ NGINX_HSTS_MAX_AGE }}variable in program_console.j2 and learner_portal.j2
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| playbooks/roles/nginx/defaults/main.yml | Increases default HSTS max-age from 1 year to 2 years |
| playbooks/roles/nginx/templates/edx/app/nginx/sites-available/xqueue.j2 | Adds includeSubDomains and preload directives to HSTS header |
| playbooks/roles/nginx/templates/edx/app/nginx/sites-available/prospectus.j2 | Adds preload directive to HSTS header |
| playbooks/roles/nginx/templates/edx/app/nginx/sites-available/program_console.j2 | Replaces hardcoded max-age with variable and adds preload directive |
| playbooks/roles/nginx/templates/edx/app/nginx/sites-available/lms.j2 | Adds preload directive to HSTS header |
| playbooks/roles/nginx/templates/edx/app/nginx/sites-available/learner_portal.j2 | Replaces hardcoded max-age with variable and adds preload directive |
| playbooks/roles/nginx/templates/edx/app/nginx/sites-available/insights.j2 | Adds preload directive to HSTS header |
| playbooks/roles/nginx/templates/edx/app/nginx/sites-available/edx_notes_api.j2 | Adds preload directive to HSTS header |
| playbooks/roles/nginx/templates/edx/app/nginx/sites-available/conductor.j2 | Adds includeSubDomains and preload directives to HSTS header |
| playbooks/roles/nginx/templates/edx/app/nginx/sites-available/cms.j2 | Adds preload directive to HSTS header |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that the following steps are done before merging: