Open
Conversation
Collaborator
Author
|
@andreimoment Review? |
26c5dec to
59903cf
Compare
|
@jackmcpickle thank you for submitting these. I noticed a few things:
Note, I am not a maintainer for this - just someone who suggested adding the feature. I apologize for not acting on this sooner - SCSS is not my forte and it will take me a bit of time to understand all of the code and propose an update. Thank you for acting swiftly and moving this in the right direction. |
Collaborator
Author
|
@andreimoment all good. I thought I'd just start with the unnamed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #223 by adding container mixin
Currently some issue with sass-true and container mixin. Maybe a bug?