Skip to content

Feature/add conatiner queries#225

Open
jackmcpickle wants to merge 5 commits intomasterfrom
feature/add-conatiner-queries
Open

Feature/add conatiner queries#225
jackmcpickle wants to merge 5 commits intomasterfrom
feature/add-conatiner-queries

Conversation

@jackmcpickle
Copy link
Copy Markdown
Collaborator

Addresses #223 by adding container mixin

Currently some issue with sass-true and container mixin. Maybe a bug?

@jackmcpickle
Copy link
Copy Markdown
Collaborator Author

@andreimoment Review?

@jackmcpickle jackmcpickle force-pushed the feature/add-conatiner-queries branch from 26c5dec to 59903cf Compare February 27, 2023 11:32
@andreimoment
Copy link
Copy Markdown

@jackmcpickle thank you for submitting these. I noticed a few things:

  • I couldn't run the tests - adding @container to the tests results in errors - I see you've commented out that line.
  • When the @container tests run OK, I recommend:
    • adding tests using the new container units
    • adding a test for the "named: " parameter
  • I did not see any additions pertaining to the "named: ..." parameter.

Note, I am not a maintainer for this - just someone who suggested adding the feature. I apologize for not acting on this sooner - SCSS is not my forte and it will take me a bit of time to understand all of the code and propose an update.

Thank you for acting swiftly and moving this in the right direction.

@jackmcpickle
Copy link
Copy Markdown
Collaborator Author

@andreimoment all good. I thought I'd just start with the unnamed @container queries for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants