Change em's unit interval from 0.1 to 0.0625. This is because some de…#193
Open
diegopelaezie wants to merge 1 commit intoeduardoboucas:masterfrom
Open
Change em's unit interval from 0.1 to 0.0625. This is because some de…#193diegopelaezie wants to merge 1 commit intoeduardoboucas:masterfrom
diegopelaezie wants to merge 1 commit intoeduardoboucas:masterfrom
Conversation
…vices like old iPads and iPad mini don't validate the ems correclty. When using pixels, '>tablet' is converted to '>769px'. In ems, (768 / 16 = 48em) '>tablet' is converted to '>48.01em' but 48.01em in pixels is 768.16px and not 769px. The right value in ems is '>48.0625em' which then converts to the expected value.
|
The title is wrong. It doesn't make sense. It should be "0.01 to 0.0625". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some devices like old iPads and iPad mini don't validate the breakpoints in ems correctly.
Hi guys,
I found this issue in a current project so I overwrote the $unit-intervals variable in my project. But I feel this might be something you guys will want to look at and maybe update.
When using pixels a '>tablet' is compiled as '>769px'.
In ems, (768 / 16 = 48em) '>tablet' is complied as '>48.01em'. But 48.01em in pixels is 768.16px and not 769px. This is having in mind the default browser font size of 16px and html of 62.5% (10px).
The right value in ems should be '>48.0625em' which then converts to the expected value. This applies to any other em value so the interval should be 0.0625.
Any thoughts?