fix: added Required Asterisk sign in the labels#660
Open
zubairshakoorarbisoft wants to merge 1 commit intoedly-io:open-release/sumac.masterfrom
Open
fix: added Required Asterisk sign in the labels#660zubairshakoorarbisoft wants to merge 1 commit intoedly-io:open-release/sumac.masterfrom
zubairshakoorarbisoft wants to merge 1 commit intoedly-io:open-release/sumac.masterfrom
Conversation
wittjeff
suggested changes
Jun 16, 2025
wittjeff
left a comment
wittjeff
left a comment
There was a problem hiding this comment.
The asterisk is a sufficient visual mark but WCAG 2.1 wants programmatic marking of state info as well.
| ${_("Specify the {platform_name} email address or username of a student " | ||
| "here:").format(platform_name=settings.PLATFORM_NAME)} | ||
| "here*:").format(platform_name=settings.PLATFORM_NAME)} | ||
| <input type="text" name="student" placeholder="${_("Student Email or Username")}"> |
There was a problem hiding this comment.
should also have required attribute for the input here.
| <p> | ||
| ${_("Choose the graded subsection:")} | ||
| ${_("Choose the graded subsection*:")} | ||
| <select name="url"> |
There was a problem hiding this comment.
should also have required attribute for the input here.
| ## Translators: "format_string" is the string MM/DD/YYYY HH:MM, as that is the format the system requires. | ||
| ${_("Specify the extension due date and time (in UTC; please specify {format_string}).").format(format_string=format_string)}</p> | ||
| ${_("Specify the extension due date and time (in UTC; please specify {format_string}).").format(format_string=format_string)}*</p> | ||
| <p><input type="text" name="due_datetime" |
There was a problem hiding this comment.
should also have required attribute for the input here.
| ${_("Specify the extension due date and time (in UTC; please specify {format_string}).").format(format_string=format_string)}</p> | ||
| ${_("Specify the extension due date and time (in UTC; please specify {format_string}).").format(format_string=format_string)}*</p> | ||
| <p><input type="text" name="due_datetime" | ||
| placeholder="${format_string}"/> <input type="text" name="reason" placeholder="${_('Reason for extension')}" size=40 /> |
There was a problem hiding this comment.
should also have required attribute for the input here.
| ${_("Specify the {platform_name} email address or username of a student " | ||
| "here:").format(platform_name=settings.PLATFORM_NAME)} | ||
| "here*:").format(platform_name=settings.PLATFORM_NAME)} | ||
| <input type="text" name="student" placeholder="${_("Student Email or Username")}"> |
There was a problem hiding this comment.
should also have required attribute for the input here.
| <p> | ||
| ${_("Choose the graded subsection:")} | ||
| ${_("Choose the graded subsection*:")} | ||
| <select name="url"> |
There was a problem hiding this comment.
should also have required attribute for the input here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Discussion page, while adding the post, Compulsory fields are missing the required alert sign (e.g. Asterisk). So, I've added Asterisk sign on post title and content area to prevent user from posting content without it. This will prevent the error message and save user time.
Steps to Reproduce:
Open Sandbox URL
Related to overhangio/tutor-indigo#146
How Has This Been Tested?
I set up Tutor locally with the Indigo Plugin enabled (which is enabled by default). I followed the above steps to reproduce the issue, inspected the HTML on the frontend, and identified where the adjustment was needed.
Sandbox (optional):
Sandbox Link
Following Taiga tickets has been addressed in this PR(Access required):
Screenshots
Before
Merge Checklist
Post-merge Checklist