Add description to User Subscriptions EDLY-2211#181
Open
taimoor-ahmed-1 wants to merge 2 commits intodevelop-multisitefrom
Open
Add description to User Subscriptions EDLY-2211#181taimoor-ahmed-1 wants to merge 2 commits intodevelop-multisitefrom
taimoor-ahmed-1 wants to merge 2 commits intodevelop-multisitefrom
Conversation
zubair-arbi
reviewed
Dec 2, 2020
zubair-arbi
left a comment
zubair-arbi
left a comment
There was a problem hiding this comment.
@taimoor-ahmed-1 I think there is no need to add description field in UserSubscription and UserSubscriptionHistory models since it was added only for giving students an explanation about what that subscription is about (on subscription listing page only).
@ziafazal @burhandodhy What are your thoughts on this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Add description field in
UserSubscriptionandUserSubscriptionHistorymodel and return it in user subscriptions apiJIRA:
https://edlyio.atlassian.net/browse/EDLY-2211
Visible Changes:
UserSubscriptionUserSubscriptionHistoryuser-subscription-api