Open
Conversation
Owner
|
I'm not sure if this change is desirable. If you already encoded the query params why would you pass it to the |
Author
|
Sorry for the delay!
That would be one benefit, but for me the major benefit is to keep things consistent. defmodule MyHTTPClient do
use HTTPoison.Base
def get_something(query) do
get("/path/to/something", [], params: query)
end
endand I would rather have HTTPoison do the right thing with my query |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to send a request with a query as follow:
which is to encode easy using
Plug.Conn.Query.encode, as%{foo: [1, 2]}yields the correct result.However, it seems to be impossible to pass an already encoded query to
HTTPoison,as
URI.encode_queryfails.Of course, we can append directly to the URL, but as the
paramsoption already exists,I think it would be nicer to support this case as well.
This patch keeps the previous behavior when the query is not a binary, and avoid
trying to reencode it when it is already a binary.
Thank you.