Skip to content

Potential fix for code scanning alert no. 1: Uncontrolled command line #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ShankarWarang wants to merge 1 commit into
base: milestone-2
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 1: Uncontrolled command line #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions scripts/run-with-pm.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Usage: node scripts/run-with-pm.js <command>
*/

const { execSync } = require("child_process");
const { execSync, execFileSync } = require("child_process");

function detectPackageManager() {
try {
Expand All @@ -22,15 +22,18 @@
}

const pm = detectPackageManager();
const command = process.argv.slice(2).join(" ");
const argv = process.argv.slice(2);

if (!command) {
if (argv.length === 0) {

Check failure

Code scanning / CodeQL

User-controlled bypass of security check High

This condition guards a sensitive
action
Loading
, but a
user-provided value
Loading
controls it.
console.error("Error: No command provided");
process.exit(1);
}

const subcommand = argv[0];
const args = argv.slice(1);

try {
execSync(`${pm} ${command}`, { stdio: "inherit" });
execFileSync(pm, [subcommand, ...args], { stdio: "inherit" });
} catch (error) {
process.exit(error.status || 1);
}