coordinator: fix anti-affinity by moving pod-role to label#2504
Open
burgerdev wants to merge 2 commits into
Open
coordinator: fix anti-affinity by moving pod-role to label#2504burgerdev wants to merge 2 commits into
burgerdev wants to merge 2 commits into
Conversation
Labels are a bit more restrictive than annotations, but we can easily fit the pod role into a label. Doing so allows using the pod role in selectors, such as for anti-affinity (where we're already selecting by the label, which did not have an effect) or in the peerdiscovery watcher. Having a label that is separate from the pod selector labels also allows exposing Coordinator's from different controllers with services.
davidweisse
force-pushed
the
dav/annotation-vars
branch
from
7be9299 to
746a20e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Contrast Coordinator used to specify an anti-affinity based on pod role label, which was ineffective because the pod role was, in fact, an annotation. With this change, we're moving the pod role to a label.
Labels are a bit more restrictive than annotations, but we can easily fit the pod role into a label. Doing so allows using the pod role in selectors, such as for anti-affinity (where we're already selecting by the label, which did not have an effect) or in the peerdiscovery watcher. Having a label that is separate from the pod selector labels also allows exposing Coordinator's from different controllers with services.
Fixes CON-213.
Fixes CON-206.