Skip to content

kuberesource: export all annotation vars from kuberesource package#2499

Open
davidweisse wants to merge 1 commit into
mainfrom
dav/annotation-vars
Open

kuberesource: export all annotation vars from kuberesource package#2499
davidweisse wants to merge 1 commit into
mainfrom
dav/annotation-vars

Conversation

@davidweisse

@davidweisse davidweisse commented Jul 2, 2026

Copy link
Copy Markdown
Member

We define constants for contrast specific K8s annotation keys in multiple locations, mainly the cli and kuberesource packages. Since there are also multiple duplicate definitions, it makes sense to put them into one location. I put every annotation key variable we define into the kuberesource package and exported them. Any future definitions can then go there as well.

Fixes CON-192

@davidweisse davidweisse requested review from burgerdev and charludo July 2, 2026 13:09
@davidweisse davidweisse added the no changelog PRs not listed in the release notes label Jul 2, 2026
@linear-code

linear-code Bot commented Jul 2, 2026

Copy link
Copy Markdown

CON-192

@burgerdev burgerdev removed the request for review from charludo July 2, 2026 14:54

@burgerdev burgerdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread internal/kuberesource/constants.go Outdated
@davidweisse davidweisse force-pushed the dav/annotation-vars branch from 7be9299 to 746a20e Compare July 6, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PRs not listed in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants