chore: signal reviewer of migrations happening#994
Draft
lusergit wants to merge 1 commit intoedgehog-device-manager:mainfrom
Draft
chore: signal reviewer of migrations happening#994lusergit wants to merge 1 commit intoedgehog-device-manager:mainfrom
lusergit wants to merge 1 commit intoedgehog-device-manager:mainfrom
Conversation
lusergit
force-pushed
the
push-tvsxwnulrllr
branch
3 times, most recently
from
6caad7f to
8dd2ea5
Compare
lusergit
force-pushed
the
push-tvsxwnulrllr
branch
7 times, most recently
from
e88f72b to
6628db5
Compare
lusergit
force-pushed
the
push-tvsxwnulrllr
branch
6 times, most recently
from
e9161dd to
7544fe4
Compare
davidebriani
requested changes
Oct 29, 2025
lusergit
force-pushed
the
push-tvsxwnulrllr
branch
7 times, most recently
from
625b953 to
2335d6d
Compare
lusergit
force-pushed
the
push-tvsxwnulrllr
branch
3 times, most recently
from
7ee1b99 to
4db3c83
Compare
lusergit
force-pushed
the
push-tvsxwnulrllr
branch
13 times, most recently
from
eac6bae to
64a6d2d
Compare
lusergit
force-pushed
the
push-tvsxwnulrllr
branch
13 times, most recently
from
03e83e4 to
90021a0
Compare
lusergit
force-pushed
the
push-tvsxwnulrllr
branch
from
90021a0 to
9f3f1d8
Compare
OmarBrbutovic
requested changes
Mar 19, 2026
Comment on lines
+38
to
+39
| - name: Make license script executable | ||
| run: chmod +x ./tools/check-migration-timestamps.sh |
Collaborator
There was a problem hiding this comment.
There’s no need to run this step every time. You can make the script executable once with chmod +x ./tools/check-migration-timestamps.sh and commit the change. Git will track the executable permission, so it will be preserved for everyone who pulls the repository.
Suggested change
| - name: Make license script executable | |
| run: chmod +x ./tools/check-migration-timestamps.sh |
| "${{ github.event.pull_request.base.sha }}" \ | ||
| "${{ github.event.pull_request.head.sha }}" | ||
| - uses: mshick/add-pr-comment@v2 | ||
| if: ${{ steps.check-migrations.conclustion == 'failure'}} |
Collaborator
There was a problem hiding this comment.
Suggested change
| if: ${{ steps.check-migrations.conclustion == 'failure'}} | |
| if: ${{ steps.check-migrations.outcome == 'failure'}} |
| jobs: | ||
| comment: | ||
| runs-on: ubuntu-latest | ||
| secrets: inherit |
Collaborator
There was a problem hiding this comment.
This does not exist, so the CI didnt even run
Suggested change
| secrets: inherit |
When a new PR that touches migrations is made, an action is triggered to signal the reviewer: PRs that handle migrations should be merged carefully, as they need to run accordingly to the state of the repo. Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to avoid making mistakes when merging a new action in the CI checks if some changes are made to migrations, signaling the reviewer (and the merger) to pay attention to them.