Skip to content

feat(container): support create container with device request #673

Open
joshuachp wants to merge 1 commit intoedgehog-device-manager:mainfrom
joshuachp:push-uxnozzupznrt
Open

feat(container): support create container with device request #673
joshuachp wants to merge 1 commit intoedgehog-device-manager:mainfrom
joshuachp:push-uxnozzupznrt

Conversation

@joshuachp
Copy link
Copy Markdown
Collaborator

No description provided.

@joshuachp joshuachp force-pushed the push-uxnozzupznrt branch 6 times, most recently from 751bb7c to d8c3fc1 Compare March 2, 2026 16:27
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 89.02655% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.4%. Comparing base (1ff5133) to head (d8c3fc1).

Files with missing lines Patch % Lines
...ice-runtime-containers/src/store/device_request.rs 88.7% 28 Missing ⚠️
...-device-runtime-containers/src/docker/container.rs 34.7% 15 Missing ⚠️
...e-runtime-store/src/models/containers/container.rs 47.6% 11 Missing ⚠️
...time-store/src/models/containers/device_request.rs 79.3% 6 Missing ⚠️
...gehog-device-runtime-containers/src/service/mod.rs 93.9% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #673     +/-   ##
=======================================
+ Coverage   81.1%   81.4%   +0.2%     
=======================================
  Files        111     116      +5     
  Lines      16438   16991    +553     
=======================================
+ Hits       13344   13836    +492     
- Misses      3094    3155     +61     
Files with missing lines Coverage Δ
...untime-containers/src/properties/device_request.rs 100.0% <100.0%> (ø)
...og-device-runtime-containers/src/properties/mod.rs 71.4% <ø> (ø)
...evice-runtime-containers/src/requests/container.rs 96.4% <100.0%> (+<0.1%) ⬆️
...-runtime-containers/src/requests/device_request.rs 100.0% <100.0%> (ø)
...ehog-device-runtime-containers/src/requests/mod.rs 86.6% <100.0%> (+1.6%) ⬆️
...vice-runtime-containers/src/resource/deployment.rs 100.0% <100.0%> (ø)
...-runtime-containers/src/resource/device_request.rs 100.0% <100.0%> (ø)
...ehog-device-runtime-containers/src/resource/mod.rs 70.0% <ø> (ø)
...og-device-runtime-containers/src/service/events.rs 92.4% <100.0%> (+0.6%) ⬆️
...g-device-runtime-containers/src/store/container.rs 95.1% <100.0%> (+0.2%) ⬆️
... and 9 more

... and 1 file with indirect coverage changes

Components Coverage Δ
runtime 78.6% <ø> (+<0.1%) ⬆️
containers 87.6% <91.1%> (+0.2%) ⬆️
forwarder 93.3% <ø> (ø)

This will introduce support for Container Device Interfaces (CDI).

Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants