refactor(dump): retrieve dataset from store and inline dump_impl #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify dump control flow by retrieving dataset directly from dataset_store and merging dump_impl into dump, reducing indirection and improving code clarity. - Add `GetDataset` error variant for `dataset_store.get_dataset()` call - Remove `MixedDatasets` check (tables guaranteed from same dataset) - Inline `dump_impl()` into `dump()` to simplify call stack - Flatten error hierarchy by removing `DumpRangesError` enum - Rename `PartitionTaskError` to `PartitionTask` variant Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
sistemd
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify dump control flow by retrieving the dataset instance directly from the dataset store and merging
dump_implintodump, reducing indirection and improving code clarity.GetDataseterror variant fordataset_store.get_dataset()callMixedDatasetscheck (tables guaranteed from same dataset)dump_impl()intodump()to simplify call stackDumpRangesErrorenumPartitionTaskErrortoPartitionTaskvariantNote
Cursor Bugbot is generating a summary for commit 8f64ba8. Configure here.