Skip to content

fix Strict Eager Compaction predicate logic #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leoyvens wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix Strict Eager Compaction predicate logic #1415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions crates/core/dump/src/compaction/algorithm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,9 @@ impl CompactionAlgorithm {
.is_exceeded(&(candidate.size + group.size));

if state == FileState::Live {
// For live files, only compact if size limit is not exceeded.
// If it's the tail file, also require length limit to be exceeded
// (for cases where a minimum number of segments is desired before compaction).
*size_exceeded
// For live files, compact as long as size limit is not exceeded.
// This allows grouping many small files until they reach the target size.
!*size_exceeded
} else if state == FileState::Hot {
// For hot files, only compact if size limit is not exceeded,
// and both files share the same generation.
Expand Down