Port artist page changes from tempus-ng fork#456
Port artist page changes from tempus-ng fork#456tvillega wants to merge 10 commits intoeddyizm:developmentfrom
Conversation
…rcular similar artists, and improved top songs display
In order to add a toolbar with a back button in settings I needed to extend from a fragment so I converted SettingsFragment into a fragment and created SettingsContainerFragment, the latter is injected as a child of SettingsFragment inside a FrameLayout. Since SettingsContainerFragment extends from PreferenceFragmentCompat, this allows to swap it for other and, in the bigger picture, allow an arbitrary organization.
…t-categorized-album-carousels
|
Agh, I used the wrong branch as base again! The easiest fix is to just merge this PR after the other one. |
10 items take almost the entire screen, which can become tiresome to scroll now it is limited to 3 before it truncates the list and shows the See All text
Albums/EPS/Singles were including releases were the artist was featured now each of them checks explicitly that the release matches the artist the opposite check is made for AppearsOn, this way they no longer mix
|
I enabled the external integrations in Navidrome to tests this and remembered the Top Songs being too long. I also caught an error with recognizing AppearsOn and now this feat is fully functional! Top SongsLimiting visible items to 3 is visually more comfortable, pressing See all still shows the full list (here there are like 40 songs on that list). 
Albums, EPs, Singles and AppearsOnThey all explicitly check that Album Artist in the metadata matches the Artist of the page. If the artist is featured on some other album, it does not appear in the Album Artist tag, hence it is discarded. AppearsOn does the opposite check, the Album Artist must mismatch the Artist of the page. Works shockingly well. 
Album pageClicking an album (any of the Albums/EPs/Singles/AppearsOn) opens a list view with all the items. At first I thought that the list was a bad choice, but after checking an artist with an insane number of Singles/AppearsOn... I thanked it lol -- clicking one leads to the normal album page. 
More like thisI had to enable external integrations in Navidrome to test it, it looks great! 
I once again thank the original author beeetfarmer, this feature is amazing and I think that it completes Tempus. |
|
Let me know if you want me to help resolve these conflicts so we can merge this in. |
|
@eddyizm could you check It seems that the merge went wrong, git offered me to add a whole section (which I accepted) but the IDE says that none of those functions were previously imported. I am a bit confused, since the refactor to settings is part of an unmerged PR and not from the development branch so I have no idea why the merge included all of those functions. |
|
I think commit fe324b6 slipped through here. |
|
Hi @tvillega I'll take a look! |
No worries. I will take some time and look at our queue, there's some I have been wanting to bring in but need to coordinate and priorities. I'll bring that other one in next - I am trying to load up locally and test out in the real world for a week or two before releasing, hoping this work flow lets me catch more stuff before publishing. At least until I redo the action to release a dev pre-release build. |
3 participants
Taken from beeetfarmer/tempus-ng fork.
Solves #180, #351 and #391.
Needs testing, particularly the sections Appears On, Top Songs and Related Artists.
Screenshots
Before | After
Clicking See all opens this view: