feat: verification flight quality gate by eddycek · Pull Request #430 · eddycek/fpvpidlab

eddycek · 2026-04-09T09:46:52Z

Summary

When a verification flight has poor or fair data quality (< 60/100), show a warning modal before completing the session
Modal displays the overall score, tier, and failing sub-scores (step count, axis coverage, etc.)
User can choose "Fly Again" (discard and retry) or "Accept Anyway" (proceed with low-quality data)
Previously the app silently accepted any verification data regardless of quality, leading to unreliable convergence detection and tune quality scores

Test plan

6 unit tests for VerificationQualityWarning component (renders, callbacks, sub-scores)
Manual: complete a PID tune with a verification flight that has < 8 stick snaps — modal should appear
Manual: "Accept Anyway" completes the session normally
Manual: "Fly Again" discards verification and shows info toast
Verify quality gate does NOT trigger for re-analyze or history record updates

🤖 Generated with Claude Code

When a verification flight has poor or fair data quality (< 60/100), show a warning modal with failing sub-scores and two options: - "Fly Again" — discard and let user retry with better stick inputs - "Accept Anyway" — proceed with low-quality verification data Previously the app silently accepted any verification data regardless of quality, which could produce unreliable convergence detection and tune quality scores. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Adds a “verification flight quality gate” to prevent completing a tuning session with low-quality verification data by showing a warning modal that summarizes overall/sub-score quality and lets the user retry or proceed.

Changes:

Introduces VerificationQualityWarning modal to present low verification data quality details and actions.
Captures dataQuality from PID/filter verification analysis results and blocks completion on fair/poor until user decision.
Adds unit tests for the new warning modal component.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
`src/renderer/components/TuningHistory/VerificationQualityWarning.tsx`	New modal UI to warn about low verification data quality and show failing sub-scores.
`src/renderer/components/TuningHistory/VerificationQualityWarning.test.tsx`	Unit tests covering rendering, sub-score filtering, callbacks, and dialog role.
`src/renderer/App.tsx`	Adds pending-verification state + commit helper, gates verification completion on `dataQuality.tier`, and wires the modal into the app flow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-09T09:51:37Z

+  const tierLabel = dataQuality.tier === 'poor' ? 'Poor' : 'Fair';
+  const tierColor = dataQuality.tier === 'poor' ? '#e74c3c' : '#f39c12';


DataQualityScore['tier'] includes 'excellent' and 'good', but this component maps any non-'poor' tier to 'Fair' (and uses the fair color). This would mislabel higher-quality tiers if the component is ever rendered with them; consider deriving the label/color from the actual tier (or asserting/handling unexpected tiers explicitly).

Suggested change

const tierLabel = dataQuality.tier === 'poor' ? 'Poor' : 'Fair';

const tierColor = dataQuality.tier === 'poor' ? '#e74c3c' : '#f39c12';

const tierDisplay: Record<DataQualityScore['tier'], { label: string; color: string }> = {

poor: { label: 'Poor', color: '#e74c3c' },

fair: { label: 'Fair', color: '#f39c12' },

good: { label: 'Good', color: '#27ae60' },

excellent: { label: 'Excellent', color: '#2ecc71' },

};

const { label: tierLabel, color: tierColor } = tierDisplay[dataQuality.tier];

Fixed — using exhaustive tier→label/color map in 22f0dcf.

Copilot · 2026-04-09T09:51:38Z

+  const handleQualityGateAccept = async () => {
+    if (!pendingVerification) return;
+    try {
+      setAnalyzingVerification(true);
+      await commitVerification(
+        pendingVerification.verificationMetrics,
+        pendingVerification.verificationPidMetrics,
+        pendingVerification.verificationTFMetrics,
+        pendingVerification.historyRecordId,
+        pendingVerification.isReanalyze
+      );
+    } catch (err) {
+      toast.error(err instanceof Error ? err.message : 'Failed to complete verification');
+    } finally {
+      setPendingVerification(null);
+      setAnalyzingVerification(false);
+    }


handleQualityGateAccept can be triggered multiple times (e.g., double-clicking “Accept Anyway”), which could run commitVerification concurrently and perform duplicate updates. Consider guarding against re-entry (disable modal buttons while accepting, clear pendingVerification before awaiting, or add an in-flight flag).

Fixed — pendingVerification is cleared before await in 22f0dcf.

Copilot · 2026-04-09T09:51:38Z

+        historyRecordId,
+        isReanalyze
+      );
      setErasedForPhase(null);


commitVerification already calls setErasedForPhase(null), so calling it again after await commitVerification(...) is redundant.

Suggested change

setErasedForPhase(null);

Fixed — removed redundant call in 22f0dcf.

Address CodePilot feedback: - Use exhaustive tier→label/color map instead of ternary - Clear pendingVerification before await to prevent double-click - Remove redundant setErasedForPhase (already in commitVerification) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

3099→3105 tests, 144→145 files after #429/#430. Add new component to renderer CLAUDE.md and TESTING.md inventory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings April 9, 2026 09:46

Copilot started reviewing on behalf of eddycek April 9, 2026 09:47 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

eddycek and others added 2 commits April 9, 2026 12:35

chore: remove accidentally committed worktree submodules

405e849

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

eddycek merged commit 2422ce5 into main Apr 9, 2026
1 check passed

eddycek deleted the feat/verification-quality-gate branch April 9, 2026 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: verification flight quality gate#430

feat: verification flight quality gate#430
eddycek merged 3 commits intomainfrom
feat/verification-quality-gate

eddycek commented Apr 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

eddycek Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

eddycek Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

eddycek Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const tierLabel = dataQuality.tier === 'poor' ? 'Poor' : 'Fair';
		const tierColor = dataQuality.tier === 'poor' ? '#e74c3c' : '#f39c12';

-  const tierLabel = dataQuality.tier === 'poor' ? 'Poor' : 'Fair';
-  const tierColor = dataQuality.tier === 'poor' ? '#e74c3c' : '#f39c12';
+  const tierDisplay: Record<DataQualityScore['tier'], { label: string; color: string }> = {
+    poor: { label: 'Poor', color: '#e74c3c' },
+    fair: { label: 'Fair', color: '#f39c12' },
+    good: { label: 'Good', color: '#27ae60' },
+    excellent: { label: 'Excellent', color: '#2ecc71' },
+  };
+  const { label: tierLabel, color: tierColor } = tierDisplay[dataQuality.tier];

Conversation

eddycek commented Apr 9, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

eddycek Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

eddycek Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

eddycek Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants