Skip to content

Fix: Executor overwrites Earthmover errors when using fallback encoding #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johncmerfeld merged 1 commit into from
Mar 20, 2026
Merged

Fix: Executor overwrites Earthmover errors when using fallback encoding #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions executor/executor/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,11 @@ def earthmover_run(self):
if err.stderr and "codec can't decode" in err.stderr and self.input_sources["INPUT_FILE"]["encoding"] != "ISO-8859-1":
self.logger.error(f"Failed to read file with {self.input_sources['INPUT_FILE']['encoding']} encoding. Retrying with Latin1...")
try:
# attempt no. 2
subprocess.run(
# attempt no. 2 - need a new em object to overwrite the decoding error
em = subprocess.run(
["earthmover", "-c", self.wrapper_earthmover, "run", "--results-file", artifact.EM_RESULTS.path, "--set", "sources.input.encoding", "iso-8859-1"],
).check_returncode()
)
em.check_returncode()

fatal = False # if we made it this far, we can abort the shutdown
except subprocess.CalledProcessError:
Expand Down