WIP: Executor: more errors than you require#26
Draft
johncmerfeld wants to merge 3 commits intodevelopmentfrom
Draft
WIP: Executor: more errors than you require#26johncmerfeld wants to merge 3 commits intodevelopmentfrom
johncmerfeld wants to merge 3 commits intodevelopmentfrom
Conversation
johncmerfeld
added
enhancement
johncmerfeld
commented
Feb 17, 2026
| # TODO: there's a potential for a hierarchy of errors here but I don't think it buys us anything | ||
| class EarthmoverWrongFileError(ExecutorError): | ||
| def __init__(self, stacktrace=None): | ||
| super().__init__("earthmover_txt", stacktrace) |
Collaborator
Author
There was a problem hiding this comment.
Note to self: wrong code
johncmerfeld
commented
Feb 17, 2026
| # Like if we say "input_file_error" I worry that ascribes too much certainty when we are not always certain | ||
| # could be easily swayed the other way though | ||
|
|
||
| # TODO: there's a potential for a hierarchy of errors here but I don't think it buys us anything |
Collaborator
Author
There was a problem hiding this comment.
"Details" messages to the user can live in these error definitions. Right now we're using a default "ensure you're using an unmodified version of the vendor file" message which could just become the fallback
Collaborator
Author
There was a problem hiding this comment.
Could leave these all as earthmover_run but with different messages, although I like having separate error codes as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a conversation starter. There's a few things in it that we should absolutely do:
But the real change is seeing how granular we can get with interpreting Earthmover errors. I put forth an aggressive take on this. I think some of these error codes would help the user out and all of them would help us with monitoring / support. I use the term "hints" because sifting through stderr is always going to be somewhat vibes based. But since Earthmover is under our roof, it's overly cautious to treat these strings as unstable. Presuming I test this code robustly, what I want to know is: do you agree? As I say, some of these would warrent some additional UI ("your load failed and it's because you uploaded an Excel file!") and some of them just reduce the depth of investigation required for routine issues.
Separately, I wonder if there's a better way to process lightbeam send errors, and whether we're too lenient with them right now...