Skip to content

feature/TDOE enhancements/fixes to the suite of models for Student Program Associations and Disabilities#212

Closed
smckee-tnedu wants to merge 1 commit intoedanalytics:mainfrom
tnedu:feature/tdoe_student_program_assoc_enhancements
Closed

feature/TDOE enhancements/fixes to the suite of models for Student Program Associations and Disabilities#212
smckee-tnedu wants to merge 1 commit intoedanalytics:mainfrom
tnedu:feature/tdoe_student_program_assoc_enhancements

Conversation

@smckee-tnedu
Copy link
Copy Markdown
Contributor

Description & motivation

Tennessee needs additional data exposed for Student Program Associations. This PR contains many changes to support this, including:

  1. The addition of a fct_student_disability model (plus supporting models) that will expose Student Disabilities that exist either on the Student EdOrg Association or the Student Special Education Program Association.
  2. The addition of a fct_student_program_participation_status model that will expose Student X Program Association participation statuses.
  3. All Student Program Association tables now contain a k_student_program surrogate key that includes the Association ed_org_id as a field. This will be the new PK across all the Student X Program Association tables. The previous implementation did not include the Association ed_org_id and this was a bug.
  4. Ed_Org_Id is exposed in all the tables now.
  5. I attempted to update all the documentation and make it correct.

Breaking changes introduced by this PR:

This will POTENTIALLY contain breaking changes if other users expect the existing bug to produce results in the "bug way" instead of the intended way of how the endpoint was designed to work.

PR Merge Priority:

  • Low
  • Medium
  • High

Changes to existing files:

  • macros/accordion_columns.sql : The current implementation creates a trailing comma. The version I have provided allows that to be explicitly set. If not set then it performs the current behavior.
  • models/core_warehouse/fct_student_cte_program_associations.sql : Added k_student_program surrogate key and ed_org_id.
  • models/core_warehouse/fct_student_cte_program_associations.yml : Updated documentation.
  • models/core_warehouse/fct_student_homeless_program_association.sql : Added k_student_program surrogate key and ed_org_id.
  • models/core_warehouse/fct_student_homeless_program_association.yml : Updated documentation.
  • models/core_warehouse/fct_student_language_instruction_program_association.sql : Added k_student_program surrogate key and ed_org_id.
  • models/core_warehouse/fct_student_language_instruction_program_association.yml : Updated documentation.
  • models/core_warehouse/fct_student_migrant_education_program_associations.sql : Added k_student_program surrogate key and ed_org_id.
  • models/core_warehouse/fct_student_migrant_education_program_associations.yml : Updated documentation.
  • models/core_warehouse/fct_student_program_association.sql : Added k_student_program surrogate key and ed_org_id.
  • models/core_warehouse/fct_student_program_association.yml : Updated documentation.
  • models/core_warehouse/fct_student_program_service.sql : Modified this to fix a couple of bugs where a couple columns MIGHT not exist, but also added the program services from the generic program endpoint.
  • models/core_warehouse/fct_student_program_service.yml : Tweak to keep it up to date based on the changes I made.
  • models/core_warehouse/fct_student_school_food_service_program_associations.sql : Added k_student_program surrogate key and ed_org_id.
  • models/core_warehouse/fct_student_school_food_service_program_associations.yml : Updated documentation.
  • models/core_warehouse/fct_student_special_education_program_association.sql : Added k_student_program surrogate key and ed_org_id.
  • models/core_warehouse/fct_student_special_education_program_association.yml : Updated documentation.
  • models/core_warehouse/fct_student_title_i_part_a_program_association.sql : Added k_student_program surrogate key and ed_org_id.
  • models/core_warehouse/fct_student_title_i_part_a_program_association.yml : Updated documentation.

New files created:

  • models/build/edfi_3/students/bld_ef3__student__disabilities.sql : This is a new build file of student disabilities across the Edfi spectrum. At the time of this writing, student disabilities could come in on the Ed Org and Student Special Education endpoints. So this build table has disabilities from both those sources.
  • models/build/edfi_3/students/bld_ef3__student__wide_disability_designations.sql : This is a new build file of student disability designations across the Edfi spectrum. This uses a new xwalk: xwalk_disability_designations. This flattens disability designations to be used later when building the fact table.
  • models/core_warehouse/fct_student_disability.sql : This new fact table is what exposes student disabilities within the warehouse.
  • models/core_warehouse/fct_student_disability.yml : I tried to follow your pattern here.
  • models/core_warehouse/fct_student_program_participation_status.sql : New fact table that exposes student program association participation statuses.
  • models/core_warehouse/fct_student_program_participation_status.yml : Documentation

Tests and QC done:

I have done internal testing and this is going through our QA process now.

edu_wh PR Review Checklist:

Make sure the following have been completed before approving this PR:

  • Description of changes has been added to Unreleased section of CHANGELOG.md. Add under ## New Features for features, etc.
  • Code has been tested/checked for Databricks and Snowflake compatibility - EA engineers see Databricks checklist here
  • Reviewer confirms the grain of all tables are unchanged, OR any changes are expected, communicated, and this PR is flagged as a breaking change (not for patch release)
  • If a new configuration xwalk was added:
    • The code is written such that the xwalk is optional (preferred), and this behavior was tested, OR
    • The code is written such that the xwalk is required, and the required xwalk is added to edu_project_template, and this PR is flagged as breaking change (not for patch release)
    • A description for the new xwalk has been added to EDU documentation site here
  • If a new configuration variable was added:
    • The code is written such that the variable is optional (preferred), and this behavior was tested, OR
    • The code is written such that the variable is required, and a default value was added to edu_project_template, and this PR is flagged as breaking change (not for patch release)
    • A description for the new variable has been added to EDU documentation site here

@smckee-tnedu
Copy link
Copy Markdown
Contributor Author

I am closing this PR because it has been replaced by a newer one that sits on top of 0.6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant