feature/TDOE enhancements/fixes to the suite of models for Student Program Associations and Disabilities#212
Closed
smckee-tnedu wants to merge 1 commit intoedanalytics:mainfrom
Conversation
…ssociations and student disabilities
13 tasks
Contributor
Author
|
I am closing this PR because it has been replaced by a newer one that sits on top of 0.6.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
Tennessee needs additional data exposed for Student Program Associations. This PR contains many changes to support this, including:
Breaking changes introduced by this PR:
This will POTENTIALLY contain breaking changes if other users expect the existing bug to produce results in the "bug way" instead of the intended way of how the endpoint was designed to work.
PR Merge Priority:
Changes to existing files:
macros/accordion_columns.sql: The current implementation creates a trailing comma. The version I have provided allows that to be explicitly set. If not set then it performs the current behavior.models/core_warehouse/fct_student_cte_program_associations.sql: Added k_student_program surrogate key and ed_org_id.models/core_warehouse/fct_student_cte_program_associations.yml: Updated documentation.models/core_warehouse/fct_student_homeless_program_association.sql: Added k_student_program surrogate key and ed_org_id.models/core_warehouse/fct_student_homeless_program_association.yml: Updated documentation.models/core_warehouse/fct_student_language_instruction_program_association.sql: Added k_student_program surrogate key and ed_org_id.models/core_warehouse/fct_student_language_instruction_program_association.yml: Updated documentation.models/core_warehouse/fct_student_migrant_education_program_associations.sql: Added k_student_program surrogate key and ed_org_id.models/core_warehouse/fct_student_migrant_education_program_associations.yml: Updated documentation.models/core_warehouse/fct_student_program_association.sql: Added k_student_program surrogate key and ed_org_id.models/core_warehouse/fct_student_program_association.yml: Updated documentation.models/core_warehouse/fct_student_program_service.sql: Modified this to fix a couple of bugs where a couple columns MIGHT not exist, but also added the program services from the generic program endpoint.models/core_warehouse/fct_student_program_service.yml: Tweak to keep it up to date based on the changes I made.models/core_warehouse/fct_student_school_food_service_program_associations.sql: Added k_student_program surrogate key and ed_org_id.models/core_warehouse/fct_student_school_food_service_program_associations.yml: Updated documentation.models/core_warehouse/fct_student_special_education_program_association.sql: Added k_student_program surrogate key and ed_org_id.models/core_warehouse/fct_student_special_education_program_association.yml: Updated documentation.models/core_warehouse/fct_student_title_i_part_a_program_association.sql: Added k_student_program surrogate key and ed_org_id.models/core_warehouse/fct_student_title_i_part_a_program_association.yml: Updated documentation.New files created:
models/build/edfi_3/students/bld_ef3__student__disabilities.sql: This is a new build file of student disabilities across the Edfi spectrum. At the time of this writing, student disabilities could come in on the Ed Org and Student Special Education endpoints. So this build table has disabilities from both those sources.models/build/edfi_3/students/bld_ef3__student__wide_disability_designations.sql: This is a new build file of student disability designations across the Edfi spectrum. This uses a new xwalk: xwalk_disability_designations. This flattens disability designations to be used later when building the fact table.models/core_warehouse/fct_student_disability.sql: This new fact table is what exposes student disabilities within the warehouse.models/core_warehouse/fct_student_disability.yml: I tried to follow your pattern here.models/core_warehouse/fct_student_program_participation_status.sql: New fact table that exposes student program association participation statuses.models/core_warehouse/fct_student_program_participation_status.yml: DocumentationTests and QC done:
I have done internal testing and this is going through our QA process now.
edu_wh PR Review Checklist:
Make sure the following have been completed before approving this PR:
## New Featuresfor features, etc.