Merged
Conversation
rlittle08
requested changes
Nov 12, 2025
Collaborator
rlittle08
left a comment
There was a problem hiding this comment.
I think this is a very smart design, and easy to read, which is surprising given how confusing of a problem it is. I have a lot of small ideas but wouldn't change the overall approach at all
… orig cols if feature disabled
rlittle08
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
Link to Jira ticket with longer description
Breaking changes introduced by this PR:
This feature by default will change nothing, so it's not inherently breaking. However, this feature has major impacts when turned on and must be carefully configured to ensure proper data access for historical assessment records.
PR Merge Priority:
Changes to existing files:
fct_student_assessment: When configured, student assessment records will be 'duplicated' across all tenants where a student (based onstudent_unique_id) has a current enrollment.dim_assessment: When this feature is configured, assessment records will be 'duplicated' across any tenants where there are student records and the metadata for that assessment/tenant/year combo does not exist.New files created:
bld_ef3__student_assessment_cross_tenant: This model is where we determine which tenants students are currently enrolled in, and then associate an originalk_student_assessmentvalue to all of those tenants, regardless of the tenant it was originally associated to. This is basically a linking model, and then all downstream models can use this information as-needed.Tests and QC done:
edu_wh PR Review Checklist:
Make sure the following have been completed before approving this PR:
## New Featuresfor features, etc.Future ToDos & Questions:
student_unique_idis globally unique. That might not be true for some multi-tenant implementations, but not currently so we are not making the ID type configurable at this time.