draft of optionally not requiring stu_ed_org to reach dim_student#148
Draft
ejoranlienea wants to merge 1 commit intomainfrom
Draft
draft of optionally not requiring stu_ed_org to reach dim_student#148ejoranlienea wants to merge 1 commit intomainfrom
ejoranlienea wants to merge 1 commit intomainfrom
Conversation
Concept: for some downstream reporting purposes, it is confusing for a record not to be in, e.g. 'enrollment' because the student is not in stuEdOrg -- this is an implicit requirement that is hard for folks to understand. We may decide to remove this logic and _always_ left join in the future, but this branch puts it behind an optional flag to let us try it out before committing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concept: for some downstream reporting purposes, it is confusing for a record not to be in, e.g. 'enrollment' because the student is not in stuEdOrg -- this is an implicit requirement that is hard for folks to understand. We may decide to remove this logic and always left join in the future, but this branch puts it behind an optional flag to let us try it out before committing.