Feature/implicit teacher role assignment

[sleblanc23]

Related to TX-119

Allows a teacher to be included in the users file based on a staff section association only, regardless of staff classification or whether they have a staff school association at all. Opt-in functionality that includes the ability to filter by classroom_position and therefore exclude aides, substitutes, etc.

I tested this in CA by excluding some teachers from fct_staff_school_association and ensuring that they are still included in the model if oneroster:require_staff_assignment = true and they had one of the configured classroom_positions. Also confirmed that the behavior is unchanged if neither new variable is set.

[rlittle08]

@sleblanc23 do you need someone to run in TX to confirm it's working there?

[sleblanc23]

yeah we should do that. I could ask Greg when he's back next week, I think he recently got access

[rlittle08]

@sleblanc23 I can do it! I volunteered to review this from TX lens

[rlittle08]

@sleblanc23 @ejoranlienea notes from my testing in TX:

1. 👍 I turned off require_staff_assignment:

  'oneroster:require_staff_assignment': False

As a result, I see 10723 new staffs in the users table, which lines up with staffs who were dropped bc of no staff_school_assoc:

select * from dev_analytics.dev_rl_oneroster_1_1.users
where "metadata.edu.natural_key" not in (select "metadata.edu.natural_key" from analytics.prod_oneroster_1_1.users);

(so the code is working as expected)

2. ❓ I did NOT configure classroom_positions. These are what I see in TX, should any be removed?

Assistant Teacher
PK Classroom Aide
Substitute Teacher
Support Teacher
Teacher Of Record
Teacher of Record

3. ❓ I noticed that >30k staff / 47k in TX are being dropped here:
   

   edu_ext_oneroster/models/oneroster_1_1/or1_1__int_users_staff.sql

   Lines 103 to 104 in 3b6bb7f

   	join user_ids
   	on dim_staff.k_staff = user_ids.k_staff

   
   Is it right that we require edOrgIdCodes to exist to be a valid user?

[rlittle08]

one other thing, I noticed in texas testing that SSNs are being included in "userIds". At the texas internal meeting we decided to explicitly remove these from the oneroster code. I am working on testing that code

[rlittle08]

SSN code is working in TX.

2 last things when you both have some time -

@sleblanc23 could you please review my last commit re: ssns?

@ejoranlienea can you review my questions 2 & 3 in comment above?

[sleblanc23]

@rlittle08 just checking that we'd always want to filter out SSNs, right? So this is fine as core code and non-configurable?

[rlittle08]

@sleblanc23 I lean always, but I can see how it'd be annoying to come back and make it configurable later. Maybe I add config but default it to filter them out