Feature/inLineSource: adding another source type#131
Draft
Feature/inLineSource: adding another source type#131
Conversation
jayckaiser
reviewed
Oct 16, 2024
| ) | ||
| raise | ||
|
|
||
| class inLineSource(Source): |
Collaborator
There was a problem hiding this comment.
Consider InlineSource to fit convention of other nodes.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
From this Monday item:
This PR supports this feature by adding a new inLineSource class with minor refactoring to other helper classes.
PR Merge Priority:
Changes to existing files:
source.py: Add an inLineSource classruns_file.py: Import inLineSource class to take care of file-hashingcolumn.py: Cast dict vals to str type in a lambdato appropriately join row values togetherTests and QC done:
earthmover_edfi_bundles