New RotateAirflowLogs DAG for deleting empty log directories#79
Open
New RotateAirflowLogs DAG for deleting empty log directories#79
Conversation
Author
|
@rlittle08, Fyi @ea-mtenhoor commented in the Jira about wanting to discuss the scope of the design further. |
Author
|
Pushed a change to scan for empty files, via the meeting/notes from the Jira. I also updated the directory scanner to be a loop, so that it handles nested empty directories. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links:
Testing instructions:
In a stadium or stadium-like project, import the new DAG and instantiate it like:
This DAG support configuration via
airflow_config.ymlunder the keyrotate_logs_dag. For example, if your logs root directory is located someplace besides$AIRFLOW_HOME/logs, you can configure it like:then update your instantiation code to load the config:
Finally, when you run the DAG, confirm that it runs successfully, that empty sub-directories in the logging directory are deleted, and non-empty directories are not deleted. The DAG uses
os.rmdir(), which will throw an exception if called on a non-empty directory, so there should not be a risk of deleting non-empty directories.