Develop SharefileToSnowflakeDag class (GF)#76
Open
gfitzgerald-ea wants to merge 48 commits intomainfrom
Open
Conversation
…xposure of dag id
… wrappers for each python operator and python callable
…r in the airflow class I'm building. Merge branch 'feature/SharefileToDiskOperator-single-file-handling-expansion' into feature/sharefile_to_snowflake_dag_builder
sleblanc23
reviewed
Aug 27, 2025
sleblanc23
reviewed
Oct 15, 2025
| 's3_conn_id': self.s3_conn_id, | ||
| 'bucket': self.s3_bucket, | ||
| 'base_dir': self.local_base_path, | ||
| 'delete_local': False, |
Contributor
There was a problem hiding this comment.
Hey Greg, could this be configurable? Just got an error related to disk space and realized the DAG wasn't cleaning up after itself
Author
There was a problem hiding this comment.
Sure! Is it fine if I include this change with the other updates we have discussed? Or should I make a quick fix ASAP to avoid the disk space issue in the meantime?
Contributor
There was a problem hiding this comment.
With the other updates is fine, thanks for asking!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sleblanc23