Remove symfony/console, migrate console layer to entropy/entropy#27
Merged
Conversation
ECS no longer depends on symfony/console. The console layer runs on entropy/entropy: commands implement Entropy's CommandInterface (run() params are the CLI contract), and a new EasyCodingStandardStyle wraps entropy's OutputPrinter/ProgressBar. - commands (Check/Worker/ListCheckers) implement entropy CommandInterface; delete AbstractCheckCommand and the Symfony console application - replace SymfonyStyle with EasyCodingStandardStyle over entropy output; delete SymfonyStyleFactory - ConfigurationFactory builds Configuration from plain args instead of InputInterface; container resolves config from raw argv - ParallelFileProcessor passes plain option values to the decoupled WorkerCommandLineFactory (symplify/easy-parallel dev-main) - bin/ecs.php parses argv manually (xdebug, --version via Composer InstalledVersions, decoration-flag stripping, -c to --config) - drop dead Option CLI-name constants - composer: drop symfony/console from require, satisfy php-cs-fixer's constraint via replace; require easy-parallel dev-main
- CommandRegistrationTest: commands are discovered and wired into Entropy's CommandRegistry (check/worker/list-checkers registered, check is default, worker is hidden) - EasyCodingStandardStyleTest: Symfony console tags are translated into Entropy's OutputColorizer vocabulary (comment/info/options/closing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECS no longer depends on symfony/console. The console layer runs on entropy/entropy: commands implement Entropy's CommandInterface (run() params are the CLI contract), and a new EasyCodingStandardStyle wraps entropy's OutputPrinter/ProgressBar.