Finished User Interface Setup section in Part 1: Sudoku Board Setup#81
Open
mathonsunday wants to merge 3 commits intoeconchick:masterfrom
mathonsunday:master
Open
Finished User Interface Setup section in Part 1: Sudoku Board Setup#81mathonsunday wants to merge 3 commits intoeconchick:masterfrom mathonsunday:master
mathonsunday wants to merge 3 commits intoeconchick:masterfrom
mathonsunday:master
Conversation
Contributor
|
Thank you for doing this! |
Owner
|
@mathonsunday - just wanted to let you know that I haven't forgotten about this! Hopefully I can set time to review next week. Thank you so much! |
Contributor
There was a problem hiding this comment.
This first line is missing four spaces, like other code snippets in this file (the first and last one are good).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the post you have the line "We'll now define a class for our UI,
SudokuUI(Frame), and go through each function." So I went through each function in the class.Note: I will be working on more of the tutorial. I am just sending PRs as I finish logical chunks.