API tutorial - giantbomb API now requires user agent#200
Open
nickdavidhaynes wants to merge 1 commit intoeconchick:masterfrom
Open
API tutorial - giantbomb API now requires user agent#200nickdavidhaynes wants to merge 1 commit intoeconchick:masterfrom
nickdavidhaynes wants to merge 1 commit intoeconchick:masterfrom
Conversation
Contributor
|
LGTM, thanks for the report and patch! |
|
I was going to add some similar code to ensure that people knew they had to use a user-agent for the giatbomb api. As of a couple days ago, @nickdavidhaynes 's changes hadn't been pulled into @econchick 's master branch. Are there any plans to do this? How does that work? |
Contributor
|
I tend to give feedback on PRs but leave the final review and approval to @econchick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was taking a look at the API tutorial and kept getting 403 return when calling the giantbomb API.
Googling uncovered this forum post from a month ago - http://www.giantbomb.com/forums/api-developers-3017/api-call-throws-error-403-forbidden-1496714/?page=1#js-message-8232912
Looks like giantbomb API now requires a (arbitrary) user agent. Adding this line fixes the 403.