Skip to content

Fix/queue id only, don't requeue on error #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peshence merged 2 commits into from
Dec 17, 2025
Merged

Fix/queue id only, don't requeue on error #153

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
906f0dc
fix(broker): only queue request id rather than the whole request
peshence Dec 9, 2025
a74f2b9
fix(broker): don't requeue on failure
peshence Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions polytope_server/broker/broker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,11 @@ def enqueue(self, request: PolytopeRequest):
# Must update request_store before queue, worker checks request status immediately
request.set_status(Status.QUEUED)
self.request_store.update_request(request)
msg = queue.Message(request.serialize())
msg = queue.Message(body={"id": request.id})
self.queue.enqueue(msg)
except Exception as e:
# If we fail to call this, the request will be stuck (POLY-21)
logging.exception("Failed to queue, error: {}".format(repr(e)))
self.request_store.set_request_status(request, Status.WAITING)
self.request_store.set_request_status(request, Status.FAILED)
else:
logging.info("Queued request")