Fix scaling of missing values in encode-mtg2 action#248
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #248 +/- ##
===========================================
- Coverage 56.35% 56.34% -0.02%
===========================================
Files 321 321
Lines 21141 21145 +4
Branches 1679 1680 +1
===========================================
Hits 11915 11915
- Misses 9226 9230 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HCookie
previously approved these changes
Mar 13, 2026
Member
HCookie
left a comment
HCookie
left a comment
There was a problem hiding this comment.
Thanks, with this and a key update, works for me
stefaniereuter
requested changes
Mar 16, 2026
Member
|
This is a blocking bug to the AIFS v2 adoption of multio, can this be resolved as soon as possible? |
tweska
force-pushed
the
fix/encode-mtg2-scaling
branch
from
0e13736 to
d372dab
Compare
tweska
force-pushed
the
fix/encode-mtg2-scaling
branch
from
d372dab to
cbda369
Compare
Member
Author
|
I removed the |
HCookie
approved these changes
Mar 18, 2026
Missing values should not be scaled
tweska
force-pushed
the
fix/encode-mtg2-scaling
branch
from
cbda369 to
9a8f45b
Compare
dsarmany
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR skips missing values in the scaling logic in the encode-mtg2 action to be consistent with the scale action.
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-248