Draft
Conversation
fd98952 to
a0d999b
Compare
__builtin_unreachable()__builtin_unreachable()
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #173 +/- ##
===========================================
- Coverage 60.89% 60.88% -0.01%
===========================================
Files 309 309
Lines 11732 11753 +21
Branches 1035 1035
===========================================
+ Hits 7144 7156 +12
- Misses 4588 4597 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dde71ad to
b78883e
Compare
tweska
commented
Mar 2, 2026
Comment on lines
+139
to
+141
| #if defined(__INTEL_COMPILER) | ||
| __builtin_unreachable(); | ||
| #endif |
Member
Author
There was a problem hiding this comment.
This is the only case where I have not been able to remove the __builtin_unreachable() for the Intel compiler. It is not possible to collapse the else branch into the parent scope here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all occurrences of
mars2gribUnreachable();, which is an alias for__builtin_unreachable().I found only two cases where removing the__builtin_unreachable()actually produces a warning and these cases can be rewritten to avoid it.