Only raise symlink error if target exists#35
Merged
wdeconinck merged 1 commit intodevelopfrom Nov 3, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #35 +/- ##
========================================
Coverage 40.66% 40.66%
========================================
Files 48 48
Lines 10129 10129
========================================
Hits 4119 4119
Misses 6010 6010 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wdeconinck
approved these changes
Nov 3, 2025
Member
wdeconinck
left a comment
wdeconinck
left a comment
There was a problem hiding this comment.
Makes sense, thanks for this!
Contributor
Author
|
Would it be possible to have a new release with the recent changes? |
wdeconinck
added a commit
that referenced
this pull request
Jan 28, 2026
* release/2.4.0: Version 2.4.0 Manage multi-remotes (#40) Fix QA code due to updated black Add genesis information to configure.sh script as per issue #32 (#38) Fix printing of version in the generated configure/build/install scripts (#37) Only raise symlink failure error if target exists (#35) Revert to absolute symlinks if relative link generation fails (#30)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The changes merged in #30 raises an error when
archdir doesn't exist. This is a small fix to allow the target of the symlink not to exist.Contributor Declaration
By opening this pull request, I affirm the following: