-
Notifications
You must be signed in to change notification settings - Fork 4
ADR-005: Introducing model keyword for DestinE DE330 On-Demand Extremes DT. #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5db8945
ADR-004: Introducing model keyword for DestinE DE330 On-Demand Extrem…
mjg41 05315a9
Updated following Simon's comments and additional meeting with Paul w…
mjg41 aec82d1
Updated to ADR-005 as ADR-004 is already in use.
mjg41 8cb1a35
Merge branch 'adr-004-odedt-model-keyword' of github.com:mjg41/codex …
mjg41 87b6dcd
Update text in background section.
mjg41 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| # ADR-005: Model keyword for DE330 (ODEDT) | ||
|
|
||
| # Status | ||
|
|
||
| Proposed | ||
|
|
||
| # Last Updated | ||
|
|
||
| 10.03.2026 | ||
|
|
||
| # Context | ||
|
|
||
| ### Background | ||
|
|
||
| The on-demand-extremes-dt routinely runs multiple models covering the same period, such as different NWP models (ALARO, AROME, HARMONIE-AROME) as well as several impact models (AQ, Hydrology, renewables, wildfire etc.). | ||
|
|
||
| Thus, an additional axis is needed to cope with several models running with all other mars metadata identical. To this end we would introduce the model keyword to the on-demand-extremes-dt data index, as has been introduced in other datasets and contexts such as class=ai. We would add the model keyword in the same way here. Thus this represents a consistent approach in-line with other datasets. | ||
|
|
||
| Values in ecCodes are currently as follows, but would be extended as the impact models become known and well formed ( `localConcepts/destine/modelNameConcept` ): | ||
|
|
||
| - IFS | ||
| - AIFS | ||
| - ICON | ||
| - ALARO | ||
| - AROME | ||
| - HARMONIE-AROME | ||
| - \<air-quality-impact-model\> (to be updated with value from DE330) | ||
| - \<hydrology-impact-model\> (to be updated with value from DE330) | ||
| - \<wildfire-impact-model\> (to be updated with value from DE330) | ||
| - … | ||
|
|
||
| ### MARS archiving approach | ||
|
|
||
| MARS namespace: | ||
|
|
||
| <pre><code>{ | ||
| "messages": [ | ||
| { | ||
| "date": 20260211, | ||
| "time": 1200, | ||
| "expver": "0001", | ||
| "class": "d1", | ||
| "dataset": "on-demand-extremes-dt", | ||
| "georef": "u23er4", | ||
| "type": "fc", | ||
| "stream": "oper", | ||
| "step": 6, | ||
| "levtype": "sfc", | ||
| <strong>"model": "HARMONIE-AROME",</strong> | ||
| "timespan": "none", | ||
| "param": 167 | ||
| } | ||
| ] | ||
| } | ||
| </code></pre> | ||
|
|
||
| # Options Considered | ||
|
|
||
| ### 1. Include model key | ||
|
|
||
| We believe this key is necessary to index data coming from different models within the on-demand Extremes DT project. | ||
|
|
||
| # Analysis | ||
|
|
||
| - Prototype at: [text](https://github.com/ecmwf/eccodes/tree/feature/ECC-2222-model-for-de330) | ||
| - This has been introduced in other datasets such as class=ai. We would add the model keyword in the same way here. Thus this represents a consistent approach in-line with other datasets. | ||
|
|
||
| # Decision | ||
|
|
||
| Meeting was held on 06/03/2026 to discuss the proposal with: | ||
|
|
||
mjg41 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - Simon Smart | ||
| - Emanuele Danovaro | ||
| - Seb Villaume | ||
| - Robert Osinski | ||
| - Bojan Kasic | ||
|
|
||
| Following up meeting to confirm with User Services with: | ||
|
|
||
| - Paul Dando | ||
| - Bojan Kasic | ||
|
|
||
| Everyone was happy with the proposal. We will proceed with the implementation. | ||
|
|
||
| # Consequences | ||
|
|
||
| - ecCodes development to add model keyword to indexing namespace for on-demand-extremes-dt data | ||
| - metkit development to add new values of model keyword to language file. | ||
|
|
||
| # References | ||
|
|
||
| # Authors | ||
|
|
||
| - Matthew Griffith | ||
| - Sebastien Villaume | ||
| - Robert Osinski | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.