Fixes and workaround failing atlas_fctest_functionspace when fckit is compiled with -Mnotarget_temps with NVHPC#332
Merged
wdeconinck merged 1 commit intodevelopfrom Nov 10, 2025
Conversation
…with -Mnotarget_temps with NVHPC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, with nvhpc/22.11 we need to create a pointer to pass to array_view1d in atlas_Field_module when wrapping existing data. This seems not always be the case. E.g. atlas_fctest_functionspace started failing when fckit was compiled with -Mnotarget_temps (nvidia/22.11). See comment in issue ecmwf/fckit#74 (comment)
Also taken the liberty to be consistent and fix array stride computation bugs introduced with #213 . The bytes of an element was hardcoded to 8 but should be dependent on the data type.
💣💥☠️ Static Analyzer Report ☠️💥💣
https://sites.ecmwf.int/docs/atlas/static-analyzer/PR-332