Skip to content

Do spoofing in validation for empty time windows#1821

Open
shmh40 wants to merge 3 commits intodevelopfrom
shmh40/dev/1820-val-spoofing
Open

Do spoofing in validation for empty time windows#1821
shmh40 wants to merge 3 commits intodevelopfrom
shmh40/dev/1820-val-spoofing

Conversation

@shmh40
Copy link
Contributor

@shmh40 shmh40 commented Feb 6, 2026

in _get_data_windows.

Description

Without the spoofing there is a mismatch in input_tokens and input_data length as described in #1820.

Issue Number

Closes #1820

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@shmh40 shmh40 self-assigned this Feb 6, 2026
@shmh40 shmh40 added bug Something isn't working model Related to model training or definition (not generic infra) labels Feb 6, 2026
Copy link
Collaborator

@clessig clessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not merge this for the time being. I don't think it's the right fix.

@github-project-automation github-project-automation bot moved this to In Progress in WeatherGen-dev Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working model Related to model training or definition (not generic infra)

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

input_data and input_token mismatch for empty timewindow in validation

2 participants